London | 26-SDC-March | Zobeir Rigi | Sprint 3 | implement-shell-tools#502
Open
Zobeir-Rigi wants to merge 10 commits into
Open
London | 26-SDC-March | Zobeir Rigi | Sprint 3 | implement-shell-tools#502Zobeir-Rigi wants to merge 10 commits into
Zobeir-Rigi wants to merge 10 commits into
Conversation
Zobeir-Rigi
added
the
Needs Review
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Can you try rewriting these using a package to manage the arguments? This can make it easier to handle options and command line access.
| continue; | ||
| } | ||
|
|
||
| console.log(file); |
Contributor
There was a problem hiding this comment.
Are you correctly handling the -1 argument?
| console.log(lines, path); | ||
| } else if (option === "w") { | ||
| console.log(words, path); | ||
| } else if (option === "c") { |
Contributor
There was a problem hiding this comment.
You are using else if here. What if someone wanted words and chars but not lines?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Shell tools implementation: cat, ls, and wc